Refactor Pickle Read methods to use higher performance PickleIterator.

base/file_path.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_path.h"
 
 #include <string.h>
 #include <algorithm>
 
 #include "base/basictypes.h"
@@ skipping 568 matching lines @@
 #endif
 
 void FilePath::WriteToPickle(Pickle* pickle) {
 #if defined(OS_WIN)
   pickle->WriteString16(path_);
 #else
   pickle->WriteString(path_);
 #endif
 }
 
-bool FilePath::ReadFromPickle(Pickle* pickle, void** iter) {
+bool FilePath::ReadFromPickle(PickleIterator* iter) {
 #if defined(OS_WIN)
-  if (!pickle->ReadString16(iter, &path_))
+  if (!iter->ReadString16(&path_))
     return false;
 #else
-  if (!pickle->ReadString(iter, &path_))
+  if (!iter->ReadString(&path_))
     return false;
 #endif
 
   return true;
 }
 
 #if defined(OS_WIN)
 // Windows specific implementation of file string comparisons
 
 int FilePath::CompareIgnoreCase(const StringType& string1,
@@ skipping 609 matching lines @@
 #if defined(FILE_PATH_USES_WIN_SEPARATORS)
   StringType copy = path_;
   for (size_t i = 1; i < arraysize(kSeparators); ++i) {
     std::replace(copy.begin(), copy.end(), kSeparators[i], kSeparators[0]);
   }
   return FilePath(copy);
 #else
   return *this;
 #endif
 }