Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 9447036: Revert 123322 (revert didn't help) (Closed)

Created:
8 years, 10 months ago by Nico
Modified:
8 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 123322 (revert didn't help) - Revert 123149 (trying to find the cause of http://crbug.com/115479) - Windows Breakpad: Stop doing Breakpad initialisation on a thread The Breakpad setup was being done on a thread because reading metadata chrome.dll was slow, but the code has been changed to read the metadata from chrome.exe which should be faster. I need to remove the use of threading so that I can change the Breakpad enablement checks to happen only in the browser process and be inherited reliably by subprocesses. Also, this will potentially make any crashes on startup more reliably reported by Breakpad. BUG=111265 TEST=none Review URL: http://codereview.chromium.org/9423016 TBR=mseaborn@chromium.org Review URL: https://chromiumcodereview.appspot.com/9456027 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -30 lines) Patch
M chrome/app/breakpad_win.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/breakpad_win.cc View 8 chunks +7 lines, -28 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
8 years, 10 months ago (2012-02-23 22:31:10 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698