chrome/browser/ui/webui/tracing_ui.cc - Issue 9447003: Revert 123140 - Use SequencedWorkerPool for disk operations in TraceSubscriberStdio.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/tracing_ui.cc

Issue 9447003: Revert 123140 - Use SequencedWorkerPool for disk operations in TraceSubscriberStdio. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/tracing_ui.cc

===================================================================

--- chrome/browser/ui/webui/tracing_ui.cc (revision 123143)

+++ chrome/browser/ui/webui/tracing_ui.cc (working copy)

@@ -73,8 +73,7 @@

// TraceSubscriber implementation.

virtual void OnEndTracingComplete();

- virtual void OnTraceDataCollected(

- const scoped_refptr<base::RefCountedString>& trace_fragment);

+ virtual void OnTraceDataCollected(const std::string& trace_fragment);

virtual void OnTraceBufferPercentFullReply(float percent_full);

// GpuDataManagerObserver implementation.

@@ -380,7 +379,7 @@

}

void TracingMessageHandler::OnTraceDataCollected(

- const scoped_refptr<base::RefCountedString>& trace_fragment) {

+ const std::string& trace_fragment) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

base::debug::TraceResultBuffer::SimpleOutput output;

@@ -388,7 +387,7 @@

trace_buffer.SetOutputCallback(output.GetCallback());

output.Append("tracingController.onTraceDataCollected(");

trace_buffer.Start();

- trace_buffer.AddFragment(trace_fragment->data());

+ trace_buffer.AddFragment(trace_fragment);

trace_buffer.Finish();

output.Append(");");

« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/test/base/tracing.cc » ('j') | no next file with comments »