Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 9447003: Revert 123140 - Use SequencedWorkerPool for disk operations in TraceSubscriberStdio. (Closed)

Created:
8 years, 10 months ago by groby-ooo-7-16
Modified:
8 years, 10 months ago
Reviewers:
Iain Merrick
CC:
chromium-reviews, jam, kkania, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, robertshield
Visibility:
Public.

Description

Revert 123140 - Use SequencedWorkerPool for disk operations in TraceSubscriberStdio. Reverted since it causes compile failure on Win/Aura. (scoped_refptr of TraceSubscriberStdioImpl which is only forward-declared) This class was hitting a ThreadRestrictions assert because it called OpenFile on the UI thread. To reduce unnecessary copying, I've changed the OnTraceDataCollected argument from std::string to RefCountedString. BUG=None TEST=content_unittests Review URL: http://codereview.chromium.org/9333003 TBR=husky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -146 lines) Patch
M base/debug/trace_event_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M base/debug/trace_event_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/test/trace_event_analyzer_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/automation/automation_provider.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/tracing_ui.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/test/base/tracing.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/trace_controller.h View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/trace_controller.cc View 5 chunks +8 lines, -4 lines 0 comments Download
M content/browser/trace_message_filter.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/trace_subscriber_stdio.h View 2 chunks +17 lines, -11 lines 0 comments Download
M content/browser/trace_subscriber_stdio.cc View 2 chunks +41 lines, -75 lines 0 comments Download
M content/browser/trace_subscriber_stdio_unittest.cc View 1 chunk +28 lines, -22 lines 0 comments Download
M content/common/child_trace_message_filter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/common/child_trace_message_filter.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
groby-ooo-7-16
8 years, 10 months ago (2012-02-23 00:22:51 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698