Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: scm.py

Issue 9443047: Fix compatibility with Xcode4.3 git (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/gclient_scm_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scm.py
===================================================================
--- scm.py (revision 123366)
+++ scm.py (working copy)
@@ -415,7 +415,9 @@
def AssertVersion(cls, min_version):
"""Asserts git's version is at least min_version."""
if cls.current_version is None:
- cls.current_version = cls.Capture(['--version'], '.').split()[-1]
+ current_version = cls.Capture(['--version'], '.')
+ matched = re.search('version (?P<version>[0-9.]+)', current_version)
M-A Ruel 2012/02/24 01:33:27 using a named variable is a bit over IMHO, this wo
bashi 2012/02/24 01:39:58 Done.
+ cls.current_version = matched.group('version')
current_version_list = map(only_int, cls.current_version.split('.'))
for min_ver in map(int, min_version.split('.')):
ver = current_version_list.pop(0)
« no previous file with comments | « no previous file | tests/gclient_scm_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698