Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: test/win/gyptest-cl_additional_options.py

Issue 9443044: Beginnings of some msvs_... emulation (windows ninja) (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: comment fixes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/win/gyptest-cl_additional_options.py
diff --git a/test/win/gyptest-cl_additional_options.py b/test/win/gyptest-cl_additional_options.py
new file mode 100644
index 0000000000000000000000000000000000000000..d60e07880ca76dd649f1db666205dd38c529e3f4
--- /dev/null
+++ b/test/win/gyptest-cl_additional_options.py
@@ -0,0 +1,36 @@
+#!/usr/bin/env python
+
+# Copyright (c) 2012 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+Make sure additional manual flags are extracted properly.
+"""
+
+import TestGyp
+
+import subprocess
+import sys
+
+if sys.platform == 'win32':
+ test = TestGyp.TestGyp(formats=['ninja'])
Nico 2012/02/29 19:44:18 One thing that I did in the test/mac tests is that
scottmg 2012/03/01 18:09:04 Haven't done that. I'll go through them and see wh
+
+ CHDIR = 'compiler_flags'
+ test.run_gyp('additional-options.gyp', chdir=CHDIR)
+
+ ninja_file = test.built_file_path('obj/test_additional_none.ninja',
+ chdir=CHDIR)
+ # Just don't error out on build.
+
+ ninja_file = test.built_file_path('obj/test_additional_one.ninja',
+ chdir=CHDIR)
+ test.must_contain(ninja_file, 'cflags = /WEE')
+
+ ninja_file = test.built_file_path('obj/test_additional_few.ninja',
+ chdir=CHDIR)
+ test.must_contain(ninja_file, '/WEE')
+ test.must_contain(ninja_file, '/WAA')
+ test.must_contain(ninja_file, '/WOO')
+
+ test.pass_test()

Powered by Google App Engine
This is Rietveld 408576698