Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Side by Side Diff: src/api.cc

Issue 9443014: Fix redefinition of aliased elements in arguments. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Sven Panne. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2742 matching lines...) Expand 10 before | Expand all | Expand 10 after
2753 ON_BAILOUT(isolate, "v8::Object::Set()", return false); 2753 ON_BAILOUT(isolate, "v8::Object::Set()", return false);
2754 ENTER_V8(isolate); 2754 ENTER_V8(isolate);
2755 i::HandleScope scope(isolate); 2755 i::HandleScope scope(isolate);
2756 i::Handle<i::JSObject> self = Utils::OpenHandle(this); 2756 i::Handle<i::JSObject> self = Utils::OpenHandle(this);
2757 i::Handle<i::Object> value_obj = Utils::OpenHandle(*value); 2757 i::Handle<i::Object> value_obj = Utils::OpenHandle(*value);
2758 EXCEPTION_PREAMBLE(isolate); 2758 EXCEPTION_PREAMBLE(isolate);
2759 i::Handle<i::Object> obj = i::JSObject::SetElement( 2759 i::Handle<i::Object> obj = i::JSObject::SetElement(
2760 self, 2760 self,
2761 index, 2761 index,
2762 value_obj, 2762 value_obj,
2763 NONE,
2763 i::kNonStrictMode); 2764 i::kNonStrictMode);
2764 has_pending_exception = obj.is_null(); 2765 has_pending_exception = obj.is_null();
2765 EXCEPTION_BAILOUT_CHECK(isolate, false); 2766 EXCEPTION_BAILOUT_CHECK(isolate, false);
2766 return true; 2767 return true;
2767 } 2768 }
2768 2769
2769 2770
2770 bool v8::Object::ForceSet(v8::Handle<Value> key, 2771 bool v8::Object::ForceSet(v8::Handle<Value> key,
2771 v8::Handle<Value> value, 2772 v8::Handle<Value> value,
2772 v8::PropertyAttribute attribs) { 2773 v8::PropertyAttribute attribs) {
(...skipping 3414 matching lines...) Expand 10 before | Expand all | Expand 10 after
6187 6188
6188 6189
6189 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) { 6190 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) {
6190 HandleScopeImplementer* scope_implementer = 6191 HandleScopeImplementer* scope_implementer =
6191 reinterpret_cast<HandleScopeImplementer*>(storage); 6192 reinterpret_cast<HandleScopeImplementer*>(storage);
6192 scope_implementer->IterateThis(v); 6193 scope_implementer->IterateThis(v);
6193 return storage + ArchiveSpacePerThread(); 6194 return storage + ArchiveSpacePerThread();
6194 } 6195 }
6195 6196
6196 } } // namespace v8::internal 6197 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698