Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 9443014: Fix redefinition of aliased elements in arguments. (Closed)

Created:
8 years, 10 months ago by Michael Starzinger
Modified:
8 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fix redefinition of aliased elements in arguments. This refactors the way we (re)define elements to perform normalization and attribute updating at a much deeper level, thereby removing some bogus special cases in upper runtime layers. Most element setters take an indicator flag that distinguishes between setting and defining. Setting of an element causes attributes to remain unchanged, writability to be checked and callbacks to be called. Defining of an element causes attributes to be updated and callbacks to be overridden. The same approach could be taken for properties. R=svenpanne@chromium.org BUG=v8:1772 TEST=test262,test262/15.2.3.6-4-333-11 Committed: https://code.google.com/p/v8/source/detail?r=10808

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Sven Panne. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -149 lines) Patch
M src/api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/liveedit.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 5 chunks +38 lines, -15 lines 0 comments Download
M src/objects.cc View 12 chunks +82 lines, -29 lines 0 comments Download
M src/runtime.cc View 8 chunks +15 lines, -91 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
8 years, 10 months ago (2012-02-23 09:47:34 UTC) #1
Sven Panne
LGTM with a nit https://chromiumcodereview.appspot.com/9443014/diff/1/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/9443014/diff/1/src/objects.h#newcode1354 src/objects.h:1354: // remain unchanged and callbacks ...
8 years, 10 months ago (2012-02-23 11:04:20 UTC) #2
Michael Starzinger
8 years, 10 months ago (2012-02-23 11:43:42 UTC) #3
Added new patch set. Landed.

https://chromiumcodereview.appspot.com/9443014/diff/1/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/9443014/diff/1/src/objects.h#newcode1354
src/objects.h:1354: // remain unchanged and callbacks to be overridden.
On 2012/02/23 11:04:20, Sven Panne wrote:
> Defining => attributes get updated

Done.

Powered by Google App Engine
This is Rietveld 408576698