Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9443003: Remove dead WebGraphicsContext3D initialization code (Closed)

Created:
8 years, 10 months ago by jamesr
Modified:
8 years, 10 months ago
CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove dead WebGraphicsContext3D initialization code BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123353

Patch Set 1 #

Patch Set 2 : take 2 #

Patch Set 3 : fix compile errors #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -99 lines) Patch
M content/renderer/render_view_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 3 chunks +3 lines, -7 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 9 chunks +7 lines, -24 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 6 chunks +27 lines, -54 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M webkit/support/webkit_support.h View 1 chunk +1 line, -0 lines 4 comments Download
M webkit/support/webkit_support.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jamesr
8 years, 10 months ago (2012-02-23 04:32:51 UTC) #1
tony
webkit/support and webkit/tools/test_shell LGTM https://chromiumcodereview.appspot.com/9443003/diff/10001/webkit/support/webkit_support.h File webkit/support/webkit_support.h (right): https://chromiumcodereview.appspot.com/9443003/diff/10001/webkit/support/webkit_support.h#newcode32 webkit/support/webkit_support.h:32: class WebView; Nit: Did you ...
8 years, 10 months ago (2012-02-23 19:04:36 UTC) #2
apatrick_chromium
LGTM for my part.
8 years, 10 months ago (2012-02-23 19:14:34 UTC) #3
jamesr
Did you take a look at webkit/gpu, Al, or would you like someone else to ...
8 years, 10 months ago (2012-02-23 19:24:03 UTC) #4
tony
https://chromiumcodereview.appspot.com/9443003/diff/10001/webkit/support/webkit_support.h File webkit/support/webkit_support.h (right): https://chromiumcodereview.appspot.com/9443003/diff/10001/webkit/support/webkit_support.h#newcode105 webkit/support/webkit_support.h:105: WebKit::WebView* web_view, here
8 years, 10 months ago (2012-02-23 19:34:49 UTC) #5
jamesr
https://chromiumcodereview.appspot.com/9443003/diff/10001/webkit/support/webkit_support.h File webkit/support/webkit_support.h (right): https://chromiumcodereview.appspot.com/9443003/diff/10001/webkit/support/webkit_support.h#newcode105 webkit/support/webkit_support.h:105: WebKit::WebView* web_view, On 2012/02/23 19:34:49, tony wrote: > here ...
8 years, 10 months ago (2012-02-23 19:35:53 UTC) #6
tony
On 2012/02/23 19:35:53, jamesr wrote: > https://chromiumcodereview.appspot.com/9443003/diff/10001/webkit/support/webkit_support.h > File webkit/support/webkit_support.h (right): > > https://chromiumcodereview.appspot.com/9443003/diff/10001/webkit/support/webkit_support.h#newcode105 > ...
8 years, 10 months ago (2012-02-23 19:38:09 UTC) #7
apatrick_chromium
On 2012/02/23 19:24:03, jamesr wrote: > Did you take a look at webkit/gpu, Al, or ...
8 years, 10 months ago (2012-02-23 20:30:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9443003/10001
8 years, 10 months ago (2012-02-23 20:30:57 UTC) #9
commit-bot: I haz the power
8 years, 10 months ago (2012-02-23 22:37:26 UTC) #10 
Change committed as 123353

Powered by Google App Engine
This is Rietveld 408576698