Added LongJump for bailout. When trying to fix all crashes, CHECK_ALIVE did not scale well as bail…

runtime/vm/compiler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/compiler.h"
 
 #include "vm/assembler.h"
 #include "vm/ast_printer.h"
 #include "vm/code_generator.h"
 #include "vm/code_index_table.h"
@@ skipping 14 matching lines @@
 
 namespace dart {
 
 DEFINE_FLAG(bool, disassemble, false, "Disassemble dart code.");
 DEFINE_FLAG(bool, trace_compiler, false, "Trace compiler operations.");
 DEFINE_FLAG(int, deoptimization_counter_threshold, 5,
     "How many times we allow deoptimization before we disallow"
     " certain optimizations");
 DEFINE_FLAG(bool, use_new_compiler, false,
     "Try to use the new compiler backend.");
+DEFINE_FLAG(bool, trace_bailout, false, "Print bailout from new compiler.");
 
 
 // Compile a function. Should call only if the function has not been compiled.
 //   Arg0: function object.
 DEFINE_RUNTIME_ENTRY(CompileFunction, 1) {
   ASSERT(arguments.Count() == kCompileFunctionRuntimeEntry.argument_count());
   const Function& function = Function::CheckedHandle(arguments.At(0));
   ASSERT(!function.HasCode());
   const Error& error = Error::Handle(Compiler::CompileFunction(function));
   if (!error.IsNull()) {
@@ skipping 65 matching lines @@
     ParsedFunction parsed_function(function);
     const char* function_fullname = function.ToFullyQualifiedCString();
     if (FLAG_trace_compiler) {
       OS::Print("Compiling %sfunction: '%s' @ token %d\n",
                 (optimized ? "optimized " : ""),
                 function_fullname,
                 function.token_index());
     }
     Parser::ParseFunction(&parsed_function);
     if (FLAG_use_new_compiler) {
-      FlowGraphBuilder graph_builder(parsed_function);
-      graph_builder.BuildGraph();
+      LongJump* old_base = isolate->long_jump_base();
+      LongJump bailout_jump;
+      isolate->set_long_jump_base(&bailout_jump);
+      if (setjmp(*bailout_jump.Set()) == 0) {
+        FlowGraphBuilder graph_builder(parsed_function);
+        graph_builder.BuildGraph();
+      } else {
+        // We bailed out.
+        Error& bailout_error = Error::Handle(
+            isolate->object_store()->sticky_error());
+        isolate->object_store()->clear_sticky_error();
+        if (FLAG_trace_bailout) {
+          OS::Print("%s\n", bailout_error.ToErrorCString());
+        }
+      }
+      isolate->set_long_jump_base(old_base);
       // Currently, always fails and falls through to the old compiler.
     }
     CodeIndexTable* code_index_table = isolate->code_index_table();
     ASSERT(code_index_table != NULL);
     Assembler assembler;
     if (optimized) {
       // Transition to optimized code only from unoptimized code ... for now.
       ASSERT(function.HasCode());
       ASSERT(!Code::Handle(function.code()).is_optimized());
       // Do not use type feedback to optimize a function that was deoptimized.
@@ skipping 209 matching lines @@
   } else {
     result = isolate->object_store()->sticky_error();
     isolate->object_store()->clear_sticky_error();
   }
   isolate->set_long_jump_base(base);
   return result.raw();
 }
 
 
 }  // namespace dart