Issue 9439001: Disable flaking SSLUI tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9439001: Disable flaking SSLUI tests (Closed)

Created:
8 years, 10 months ago by tpayne

Modified:
8 years, 10 months ago

Reviewers:
wtc

CC:
chromium-reviews

Visibility:
Public.

More Reviews

Description

Disable flaking SSLUI tests while I continue to investigate issue. BUG=40932 TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123290

Patch Set 2 : Merged #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/ssl/ssl_browser_tests.cc	View	1	1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

TEST=NONE, otherwise LGTM. TEST line is for manual QA instructions.

8 years, 10 months ago (2012-02-22 23:18:52 UTC) #2

wtc

LGTM. http://codereview.chromium.org/9439001/diff/5001/chrome/browser/ssl/ssl_browser_tests.cc File chrome/browser/ssl/ssl_browser_tests.cc (right): http://codereview.chromium.org/9439001/diff/5001/chrome/browser/ssl/ssl_browser_tests.cc#newcode365 chrome/browser/ssl/ssl_browser_tests.cc:365: // See http://crbug.com/40932 Please add "Disabled" to this ...

8 years, 10 months ago (2012-02-23 22:15:00 UTC) #3

tpayne

8 years, 10 months ago (2012-02-23 22:16:12 UTC) #4

http://codereview.chromium.org/9439001/diff/5001/chrome/browser/ssl/ssl_brows...
File chrome/browser/ssl/ssl_browser_tests.cc (right):

http://codereview.chromium.org/9439001/diff/5001/chrome/browser/ssl/ssl_brows...
chrome/browser/ssl/ssl_browser_tests.cc:365: // See http://crbug.com/40932
On 2012/02/23 22:15:00, wtc wrote:
> 
> Please add "Disabled" to this comment.  Otherwise it's not
> clear why one should see http://crbug.com/40932.

This CL was already landed by vandebo. Another CL has been sent to you to fix
and re-enable this test.

Expand Messages | Collapse Messages

Issue 9439001: Disable flaking SSLUI tests (Closed)

Description

Patch Set 1 #

Patch Set 2 : Merged #

Messages