chrome/browser/ui/android/extensions/extension_view_android.h - Issue 9433044: Fix extensions compile issues for Android on sync_unit_tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/android/extensions/extension_view_android.h

Issue 9433044: Fix extensions compile issues for Android on sync_unit_tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Tracked issue for default_height in a bug and put bug # here. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/extension_warning_set.cc ('K') | « chrome/browser/extensions/process_map.cc ('k') | chrome/browser/ui/android/extensions/extension_view_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_ANDROID_EXTENSIONS_EXTENSION_VIEW_ANDROID_H_

	6 #define CHROME_BROWSER_UI_ANDROID_EXTENSIONS_EXTENSION_VIEW_ANDROID_H_

	7 #pragma once

	8

	9 #include "ui/gfx/size.h"

	10

	11 class Browser;

	12

	13 class ExtensionViewAndroid {

	14 public:

	15 Browser* browser() const { return NULL; }
	Yaron 2012/02/22 19:34:24 I think even dummy implementations are supposed to I think even dummy implementations are supposed to go in the cc file. David Trainor- moved to gerrit 2012/02/22 21:31:33 This is inlined in the mac/gtk. Trying to stay co Show quoted text On 2012/02/22 19:34:24, Yaron wrote: > I think even dummy implementations are supposed to go in the cc file. This is inlined in the mac/gtk. Trying to stay consistent.
	16

	17 void UpdatePreferredSize(const gfx::Size& new_size);

	18 void RenderViewCreated();

	19

	20 private:

	21 ExtensionViewAndroid() { }
	Yaron 2012/02/22 19:34:24 Need: DISALLOW_COPY_AND_ASSIGN(ExtensionViewAndroi Need: DISALLOW_COPY_AND_ASSIGN(ExtensionViewAndroid); David Trainor- moved to gerrit 2012/02/22 21:31:33 Done. Good catch :). Show quoted text On 2012/02/22 19:34:24, Yaron wrote: > Need: DISALLOW_COPY_AND_ASSIGN(ExtensionViewAndroid); Done. Good catch :).
	22 };

	23

	24 #endif // CHROME_BROWSER_UI_ANDROID_EXTENSIONS_EXTENSION_VIEW_ANDROID_H_

	25
	Yaron 2012/02/22 19:34:24 Remove empty line Remove empty line David Trainor- moved to gerrit 2012/02/22 21:31:33 Done. Show quoted text On 2012/02/22 19:34:24, Yaron wrote: > Remove empty line Done.
OLD	NEW