Fix extensions compile issues for Android on sync_unit_tests.

chrome/browser/extensions/extension_warning_set.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_warning_set.h"
 
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/extension_global_error_badge.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 93 matching lines @@
   bool inserted = warnings_.insert(warning).second;
   if (inserted) {
     NotifyWarningsChanged();
     UpdateWarningBadge();
   }
 }
 
 void ExtensionWarningSet::ClearWarnings(
     const std::set<ExtensionWarningSet::WarningType>& types) {
   bool deleted_anything = false;
-  for (const_iterator i = warnings_.begin(); i != warnings_.end();) {
+  for (iterator i = warnings_.begin(); i != warnings_.end();) {

[asargent_no_longer_on_chrome, 2012/02/22 21:47:55]

Out of curiousity, are you switching to using a non-const iterator here because
the call to erase below modifies the set?

[David Trainor- moved to gerrit, 2012/02/22 21:51:42]

It looks like our Android stl port of std::set doesn't have an erase method that
takes a const_iterator.  So this gives compile errors when I try to pass a
const_iterator to the erase call :(.

     if (types.find(i->warning_type()) != types.end()) {
       deleted_anything = true;
       warnings_.erase(i++);
     } else {
       ++i;
     }
   }
 
   if (deleted_anything) {
     NotifyWarningsChanged();
@@ skipping 60 matching lines @@
       ExtensionGlobalErrorBadge::GetMenuItemCommandID());
 
   // Activate or hide the warning badge in case the current state is incorrect.
   if (error && !need_warning_badge) {
     service->RemoveGlobalError(error);
     delete error;
   } else if (!error && need_warning_badge) {
     service->AddGlobalError(new ExtensionGlobalErrorBadge);
   }
 }