Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: src/char-predicates.h

Issue 9433031: Allow the ZWJ and ZWNJ characters in IdentifierPart as per ES5. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/char-predicates.h
===================================================================
--- src/char-predicates.h (revision 10785)
+++ src/char-predicates.h (working copy)
@@ -56,6 +56,8 @@
struct IdentifierPart {
static inline bool Is(uc32 c) {
return IdentifierStart::Is(c)
+ || c == 0x200C
+ || c == 0x200D
mathias 2012/02/22 09:49:37 As an `IdentifierStart` character is the most comm
Lasse Reichstein Nielsen 2012/02/22 14:03:28 Good thought. I'd prefer moving the number (digit,
|| unibrow::Number::Is(c)
|| unibrow::CombiningMark::Is(c)
|| unibrow::ConnectorPunctuation::Is(c);
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698