Issue 9433030: Don't rely on `touch' being available (windows ninja)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9433030: Don't rely on `touch' being available (windows ninja) (Closed)

Created:
8 years, 10 months ago by scottmg

Modified:
8 years, 10 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Don't rely on `touch' being available (windows ninja) Committed: https://code.google.com/p/gyp/source/detail?r=1227

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	pylib/gyp/generator/ninja.py	View	1 2	2 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

stamp via copy nul $file. (stamp only creates/updates empty files, right?)

8 years, 10 months ago (2012-02-22 04:32:43 UTC) #1

Nico

LGTM if this does update file mtime (which I guess is covered by tests) https://chromiumcodereview.appspot.com/9433030/diff/2001/pylib/gyp/generator/ninja.py ...

8 years, 10 months ago (2012-02-22 05:05:56 UTC) #2

scottmg

8 years, 10 months ago (2012-02-22 05:15:05 UTC) #3

On 2012/02/22 05:05:56, Nico wrote:
> LGTM if this does update file mtime (which I guess is covered by tests)

Yup.

> 
>
https://chromiumcodereview.appspot.com/9433030/diff/2001/pylib/gyp/generator/...
> File pylib/gyp/generator/ninja.py (right):
> 
>
https://chromiumcodereview.appspot.com/9433030/diff/2001/pylib/gyp/generator/...
> pylib/gyp/generator/ninja.py:1201: command='${postbuilds}cmd /c copy nul
> $out>nul')
> Do you need the ${postbuilds} bit? If not (yet), I'd leave it out. (postbuilds
> are currently a mac-only thing; this always evaluates to nothing on linux)

Nope, I wasn't sure what postbuilds was exactly doing, so I just left it the
same. Removed.

Expand Messages | Collapse Messages