Add Windows ninja to buildbot

- Make gyptest.py set up the environment in case cl/link/etc. aren't in the environment.
- Add ninja to Windows runs.
Committed: https://code.google.com/p/gyp/source/detail?r=1236

[scottmg, 2012-02-22 04:33:49]

Yay! (couple other patches to go, and then I'll make sure the trys are clean of
course)

[Nico, 2012-02-22 05:07:27]

I think you also need to update gyptest.py

Is ninja installed on that bot? On linux/mac, it's now included as part of
depot_tools, but on windows that isn't true.

[Nico, 2012-02-22 05:09:27]

…and bradnelson is probably the best reviewer for botty changes, since he
babysits them :-)

[scottmg, 2012-02-22 05:10:10]

On 2012/02/22 05:07:27, Nico wrote:
> I think you also need to update gyptest.py

Do you mean to allow -f ninja? That landed already.

> Is ninja installed on that bot? On linux/mac, it's now included as part of
> depot_tools, but on windows that isn't true.

I crammed it into depot_tools this afternoon, for better or worse.

[scottmg, 2012-02-22 05:11:26]

Adding Brad to review per suggestion.

[Nico, 2012-02-22 05:17:58]

Ah, if ninja's on the bot already then I guess a "heads up" for Brad is enough
:-)

One comment below:

http://codereview.chromium.org/9433026/diff/4005/test/lib/TestGyp.py
File test/lib/TestGyp.py (right):

http://codereview.chromium.org/9433026/diff/4005/test/lib/TestGyp.py#newcode426
test/lib/TestGyp.py:426: # make our "build tool" be set up + run ninja.
Could you share code with TestGypMSVS.initialize_build_tool() here?

[scottmg, 2012-02-22 05:59:09]

http://codereview.chromium.org/9433026/diff/4005/test/lib/TestGyp.py
File test/lib/TestGyp.py (right):

http://codereview.chromium.org/9433026/diff/4005/test/lib/TestGyp.py#newcode426
test/lib/TestGyp.py:426: # make our "build tool" be set up + run ninja.
On 2012/02/22 05:17:58, Nico wrote:
> Could you share code with TestGypMSVS.initialize_build_tool() here?

Yeah... That code seems kinda busted but I was too scared (lazy) to refactor &
fix it. I'll suck it up. :)

[scottmg, 2012-02-22 17:38:11]

On 2012/02/22 05:59:09, scottmg wrote:
> http://codereview.chromium.org/9433026/diff/4005/test/lib/TestGyp.py
> File test/lib/TestGyp.py (right):
> 
>
http://codereview.chromium.org/9433026/diff/4005/test/lib/TestGyp.py#newcode426
> test/lib/TestGyp.py:426: # make our "build tool" be set up + run ninja.
> On 2012/02/22 05:17:58, Nico wrote:
> > Could you share code with TestGypMSVS.initialize_build_tool() here?
> 
> Yeah... That code seems kinda busted but I was too scared (lazy) to refactor &
> fix it. I'll suck it up. :)

#8 is mechanical refactoring. It should be tossed and rewritten though.

[Nico, 2012-02-22 17:45:22]

LGTM, thanks!

http://codereview.chromium.org/9433026/diff/1010/test/lib/TestGyp.py
File test/lib/TestGyp.py (right):

http://codereview.chromium.org/9433026/diff/1010/test/lib/TestGyp.py#newcode480
test/lib/TestGyp.py:480: vsvars_path = os.path.join(devenv_path,
'../../Tools/vsvars32.bat')
For my education: Why not vcvarsall.bat?

http://codereview.chromium.org/9433026/diff/1010/test/lib/TestGyp.py#newcode500
test/lib/TestGyp.py:500: arguments = self.helper_args + arguments
I guess '/c' means that cmd.exe will spawn a subshell which it sets the vcvars
in, which is why this is needed for every test?

[scottmg, 2012-02-22 17:59:14]

On 2012/02/22 17:45:22, Nico wrote:
> LGTM, thanks!
> 
> http://codereview.chromium.org/9433026/diff/1010/test/lib/TestGyp.py
> File test/lib/TestGyp.py (right):
> 
>
http://codereview.chromium.org/9433026/diff/1010/test/lib/TestGyp.py#newcode480
> test/lib/TestGyp.py:480: vsvars_path = os.path.join(devenv_path,
> '../../Tools/vsvars32.bat')
> For my education: Why not vcvarsall.bat?

Mostly habit. For x86 which is all we use anyway, vcvarsall.bat calls
bin\vcvars32.bat, which calls vsvars32.bat.

More importantly, vcvarsall relies on having VS90COMNTOOLS being set (normally
set during VS installation) but it doesn't appear to be set on the bots per
explorations in try jobs here:
http://build.chromium.org/p/tryserver.nacl/builders/gyp-win64/builds/34/steps...
I guess we do some slightly sneaky install/deploy method for VS? Not 100% sure.

> 
>
http://codereview.chromium.org/9433026/diff/1010/test/lib/TestGyp.py#newcode500
> test/lib/TestGyp.py:500: arguments = self.helper_args + arguments
> I guess '/c' means that cmd.exe will spawn a subshell which it sets the vcvars
> in, which is why this is needed for every test?

That's the idea. Spawning the shell, and then running "envvars && ninja" in that
shell so that ninja has the right path and envvars available.

I guess a more complicated version could be to run vsvars in a shell && inspect
the environment to pull out important things, pass those back up to the parent
process. But, since this is for running tests the simple/reliable/slightly
slower seems better.