GTK Keyboard Support for New Autofill

chrome/browser/autofill/autofill_popup_view.h

Index: chrome/browser/autofill/autofill_popup_view.h
diff --git a/chrome/browser/autofill/autofill_popup_view.h b/chrome/browser/autofill/autofill_popup_view.h
index 1ca890871d350d846787c2da28aa1f1c505318ef..321aa3317177443397ec8edfae621a7cce507031 100644
--- a/chrome/browser/autofill/autofill_popup_view.h
+++ b/chrome/browser/autofill/autofill_popup_view.h
@@ -75,6 +75,21 @@ class AutofillPopupView : public content::NotificationObserver {
   // Change which line is currently selected by the user.
   void SetSelectedLine(int selected_line);
 
+  // Increase the selected line by 1, properly handling wrapping.
+  void SelectNextLine();
+
+  // Decrease the selected line by 1, properly handling wrapping.
+  void SelectPreviousLine();
+
+  // The user has choosen the selected line.
+  bool AcceptSelectedLine();
+
+  // The user has removed a suggestion.
+  bool RemoveSelectedLine();
+
+  // Used to indicate that no line is currently selected by the user.
+  const int kNoSelection;

[Ilya Sherman, 2012/03/27 19:09:04]

nit: There's no need to have the constant declared in the header -- please move
the whole declaration into the implementation file.

+
  private:
   // content::NotificationObserver method override.
   virtual void Observe(int type,
@@ -100,7 +115,7 @@ class AutofillPopupView : public content::NotificationObserver {
   int separator_index_;
 
   // The line that is currently selected by the user.
-  // -1 indicates that no line is currently selected.
+  // |kNoSelection| indicates that no line is currently selected.
   int selected_line_;
 };