Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 9431029: Implement interface types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add test. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/nodes.dart
diff --git a/lib/compiler/implementation/ssa/nodes.dart b/lib/compiler/implementation/ssa/nodes.dart
index 336f1f4da4fae6ad80e820cd84d6c70eb606cc77..c9b49f5c7e0c00d88747a0b73f75bd0a23ca4d35 100644
--- a/lib/compiler/implementation/ssa/nodes.dart
+++ b/lib/compiler/implementation/ssa/nodes.dart
@@ -2081,11 +2081,10 @@ class HIndexAssign extends HInvokeStatic {
}
class HIs extends HInstruction {
- // TODO(ahe): This should be a Type, not Element.
- final Element typeExpression;
+ final Type typeName;
ahe 2012/04/12 15:05:23 Thank you! The name is not optimal, if you have an
final bool nullOk;
- HIs(this.typeExpression, HInstruction expression, [nullOk = false])
+ HIs(this.typeName, HInstruction expression, [nullOk = false])
: this.nullOk = nullOk, super(<HInstruction>[expression]);
HInstruction get expression() => inputs[0];
@@ -2095,7 +2094,7 @@ class HIs extends HInstruction {
accept(HVisitor visitor) => visitor.visitIs(this);
- toString() => "$expression is $typeExpression";
+ toString() => "$expression is $typeName";
}
class HIfBlockInformation {

Powered by Google App Engine
This is Rietveld 408576698