Implement interface types.

frog/leg/typechecker.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class TypeCheckerTask extends CompilerTask {
   TypeCheckerTask(Compiler compiler) : super(compiler);
   String get name() => "Type checker";
 
   void check(Node tree, TreeElements elements) {
     measure(() {
@@ skipping 30 matching lines @@
   static final MAYBE_RETURNING = const StatementType('<maybe returning>');
 
   /** Combine the information about two control-flow edges that are joined. */
   StatementType join(StatementType other) {
     return (this === other) ? this : MAYBE_RETURNING;
   }
 
   String toString() => stringName;
 }
 
-class SimpleType implements Type {
+class TypeVariable {

[ahe, 2012/02/29 12:49:15]

What is the purpose of this class?

[karlklose, 2012/03/30 11:56:40]

Removed.

   final SourceString name;
-  final Element element;
+  final Type value;

[ahe, 2012/02/29 12:49:15]

What is this?

[karlklose, 2012/03/30 11:56:40]

Removed the class.

+  const TypeVariable(this.name, [this.value]);
+}

[ngeoffray, 2012/02/24 13:36:15]

You can remove the code above.

[karlklose, 2012/03/30 11:56:40]

Done.

 
-  const SimpleType(SourceString this.name, Element this.element);
+class InterfaceType implements Type {
+  final SourceString name;
+  final ClassElement element;
+  final Link<Type> arguments;
+  const InterfaceType(SourceString this.name, ClassElement this.element,
+                      [Link<Type> arguments = const EmptyLink<Type>()])

[ahe, 2012/02/29 12:49:15]

Why not this.arguments?

[karlklose, 2012/03/30 11:56:40]

Done.

+    : this.arguments = arguments;

[ngeoffray, 2012/02/24 13:36:15]

Add new line.

[ngeoffray, 2012/02/24 13:36:15]

Do you think it'd be more robust to write:
this.arguments = arguments == null ? const EmptyLink<Type>() : arguments;

Instead of giving a default value to arguments?

[karlklose, 2012/03/30 11:56:40]

Done.

+  toString() {
+    StringBuffer sb = new StringBuffer();
+    sb.add(name);
+    bool first = true;
+    for (Link link = arguments; !link.isEmpty(); link = link.tail) {

[ahe, 2012/02/29 12:49:15]

Could you use:
if (!arguments.isEmpty()) {
  sb.add('<');
  arguments.printOn(sb, ', ')
  sb.add('>');
}

[karlklose, 2012/03/30 11:56:40]

Done.

+      sb.add(first ? '<' : ', ');
+      sb.add(link.head);
+      if (link.tail.isEmpty()) sb.add('>');
+      first = false;
+    }
+    return sb.toString();
+  }
+}
 
+// TODO(karlklose): merge into InterfaceType as a named constructor.

[ahe, 2012/02/29 12:49:15]

+1

+class SimpleType extends InterfaceType {
+  const SimpleType(SourceString name, Element element) : super(name, element);
   String toString() => name.toString();
 }
 
 class FunctionType implements Type {
   final Element element;
   final Type returnType;
   final Link<Type> parameterTypes;
 
   const FunctionType(Type this.returnType, Link<Type> this.parameterTypes,
                      Element this.element);
@@ skipping 560 matching lines @@
   }
 
   visitCatchBlock(CatchBlock node) {
     compiler.unimplemented('visitCatchBlock', node: node);
   }
 
   visitTypedef(Typedef node) {
     compiler.unimplemented('visitTypedef', node: node);
   }
 }