Implement interface types.

frog/tests/leg/src/ResolverTest.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #import("../../../../lib/compiler/implementation/leg.dart");
 #import("../../../../lib/compiler/implementation/elements/elements.dart");
 #import("../../../../lib/compiler/implementation/tree/tree.dart");
 #import("../../../../lib/compiler/implementation/util/util.dart");
 #import("mock_compiler.dart");
 #import("parser_helper.dart");
@@ skipping 40 matching lines @@
 main() {
   testLocalsOne();
   testLocalsTwo();
   testLocalsThree();
   testLocalsFour();
   testLocalsFive();
   testParametersOne();
   testFor();
   testTypeAnnotation();
   testSuperclass();
   // testVarSuperclass(); // The parser crashes with 'class Foo extends var'.

[ahe, 2012/04/12 15:05:23]

Really?

   // testOneInterface(); // The parser does not handle interfaces.

[ahe, 2012/04/12 15:05:23]

Really?

   // testTwoInterfaces(); // The parser does not handle interfaces.

[ahe, 2012/04/12 15:05:23]

Really?

   testFunctionExpression();
   testNewExpression();
   testTopLevelFields();
   testClassHierarchy();
   testInitializers();
   testThis();
   testSuperCalls();
+  testTypeVariables();
+}
+
+testTypeVariables() {
+  testTypeResolving(visitor, text, name, expectedElements) {

[ahe, 2012/04/12 15:05:23]

I think it is confusing when a helper function starts with "test".

+    VariableDefinitions definition = parseStatement(text);
+    visitor.visit(definition.type);
+    InterfaceType type = visitor.mapping.getType(definition.type);
+    Expect.equals(definition.type.typeArguments.length(),
+                  length(type.arguments));
+    int index = 0;
+    Link<Type> arguments = type.arguments;
+    while (!arguments.isEmpty()) {

[ahe, 2012/04/12 15:05:23]

Expect.isTrue(index < expectedElements.length);

+      Expect.equals(expectedElements[index], arguments.head.element);
+      index++;
+      arguments = arguments.tail;
+    }
+  }
+
+  MockCompiler compiler = new MockCompiler();
+  ResolverVisitor visitor = compiler.resolverVisitor();
+  compiler.parseScript('class Foo<T, U> {}');
+  visitor.visit(parseStatement('Foo foo;'));

[ahe, 2012/04/12 15:05:23]

What is the purpose of this?

+  ClassElement foo = compiler.mainApp.find(buildSourceString('Foo'));
+  testTypeResolving(visitor, 'Foo<int, String> x;', 'Foo',
+                    [compiler.intClass, compiler.stringClass]);
+  testTypeResolving(visitor, 'Foo<Foo, Foo> x;', 'Foo',
+                    [foo, foo]);
+
+  compiler = new MockCompiler();
+  compiler.parseScript('class Foo<T, U> {}');
+  compiler.resolveStatement('Foo<notype, int> x;');
+  Expect.equals(1, compiler.warnings.length);
+  Expect.equals(MessageKind.CANNOT_RESOLVE_TYPE,
+                compiler.warnings[0].message.kind);
+  Expect.equals(0, compiler.errors.length);
+
+  compiler = new MockCompiler();
+  compiler.parseScript('class Foo<T, U> {}');
+  compiler.resolveStatement('var x = new Foo<notype, int>();');
+  Expect.equals(0, compiler.warnings.length);
+  Expect.equals(1, compiler.errors.length);
+  Expect.equals(MessageKind.CANNOT_RESOLVE_TYPE,
+                compiler.errors[0].message.kind);
 }
 
 testSuperCalls() {
   MockCompiler compiler = new MockCompiler();
   String script = """class A { foo() {} }
                      class B extends A { foo() => super.foo(); }""";
   compiler.parseScript(script);
   compiler.resolveStatement("B b;");
 
   ClassElement classB = compiler.mainApp.find(buildSourceString("B"));
@@ skipping 558 matching lines @@
 length(Link link) => link.isEmpty() ? 0 : length(link.tail) + 1;
 
 at(Link link, int index) => (index == 0) ? link.head : at(link.tail, index - 1);
 
 List<String> asSortedStrings(Link link) {
   List<String> result = <String>[];
   for (; !link.isEmpty(); link = link.tail) result.add(link.head.toString());
   result.sort((s1, s2) => s1.compareTo(s2));
   return result;
 }