Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 9431025: Manual path slash normalization in ExpandSpecial (windows ninja) (Closed)

Created:
8 years, 10 months ago by scottmg
Modified:
8 years, 10 months ago
Reviewers:
Nico, Evan Martin
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Manual path slash normalization in ExpandSpecial (windows ninja) Not using os.path.normpath per comment and https://groups.google.com/group/gyp-developer/browse_thread/thread/a48db62b5776922a Committed: https://code.google.com/p/gyp/source/detail?r=1226

Patch Set 1 #

Patch Set 2 : fix merge #

Total comments: 1

Patch Set 3 : flavor instead of platform #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pylib/gyp/generator/ninja.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
8 years, 10 months ago (2012-02-22 02:46:05 UTC) #1
Nico
lgtm with comment https://chromiumcodereview.appspot.com/9431025/diff/2001/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): https://chromiumcodereview.appspot.com/9431025/diff/2001/pylib/gyp/generator/ninja.py#newcode217 pylib/gyp/generator/ninja.py:217: if sys.platform == 'win32': self.flavor?
8 years, 10 months ago (2012-02-22 02:49:58 UTC) #2
scottmg
8 years, 10 months ago (2012-02-22 02:58:18 UTC) #3
On 2012/02/22 02:49:58, Nico wrote:
> lgtm with comment
> 
>
https://chromiumcodereview.appspot.com/9431025/diff/2001/pylib/gyp/generator/...
> File pylib/gyp/generator/ninja.py (right):
> 
>
https://chromiumcodereview.appspot.com/9431025/diff/2001/pylib/gyp/generator/...
> pylib/gyp/generator/ninja.py:217: if sys.platform == 'win32':
> self.flavor?

Done.

Powered by Google App Engine
This is Rietveld 408576698