Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 9430048: When redefining accessor properties, defensively copy AccessorPairs. (Closed)

Created:
8 years, 10 months ago by Sven Panne
Modified:
8 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

When redefining accessor properties, defensively copy AccessorPairs. The previous code relied on the tricky global invariant that there is no map sharing when accessor properties are involved (or in other words: that TransformToFastProperties is dumb enough :-). Although this is not a real problem with the current code, this assumption breaks when map sharing in fast mode is enabled, so we defensively copy an AccessorPair. Committed: https://code.google.com/p/v8/source/detail?r=10810

Patch Set 1 #

Patch Set 2 : When redefining accessor properties, defensively copy AccessorPairs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/objects.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 10 months ago (2012-02-22 14:48:02 UTC) #1
Michael Starzinger
8 years, 10 months ago (2012-02-23 12:05:40 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698