Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: SConstruct

Issue 9430043: Added -Woverloaded-virtual to GCC flags, syncing scons and gyp builds. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2011 the V8 project authors. All rights reserved. 1 # Copyright 2011 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 } 289 }
290 290
291 291
292 V8_EXTRA_FLAGS = { 292 V8_EXTRA_FLAGS = {
293 'gcc': { 293 'gcc': {
294 'all': { 294 'all': {
295 'WARNINGFLAGS': ['-Wall', 295 'WARNINGFLAGS': ['-Wall',
296 '-Werror', 296 '-Werror',
297 '-W', 297 '-W',
298 '-Wno-unused-parameter', 298 '-Wno-unused-parameter',
299 '-Woverloaded-virtual',
299 '-Wnon-virtual-dtor'] 300 '-Wnon-virtual-dtor']
300 }, 301 },
301 'os:win32': { 302 'os:win32': {
302 'WARNINGFLAGS': ['-pedantic', '-Wno-long-long'] 303 'WARNINGFLAGS': ['-pedantic', '-Wno-long-long']
303 }, 304 },
304 'os:linux': { 305 'os:linux': {
305 'WARNINGFLAGS': ['-pedantic'], 306 'WARNINGFLAGS': ['-pedantic'],
306 'library:shared': { 307 'library:shared': {
307 'soname:on': { 308 'soname:on': {
308 'LINKFLAGS': ['-Wl,-soname,${SONAME}'] 309 'LINKFLAGS': ['-Wl,-soname,${SONAME}']
(...skipping 1251 matching lines...) Expand 10 before | Expand all | Expand 10 after
1560 # version of scons. Also, there's a bug in some revisions that 1561 # version of scons. Also, there's a bug in some revisions that
1561 # doesn't allow this flag to be set, so we swallow any exceptions. 1562 # doesn't allow this flag to be set, so we swallow any exceptions.
1562 # Lovely. 1563 # Lovely.
1563 try: 1564 try:
1564 SetOption('warn', 'no-deprecated') 1565 SetOption('warn', 'no-deprecated')
1565 except: 1566 except:
1566 pass 1567 pass
1567 1568
1568 1569
1569 Build() 1570 Build()
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698