Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 9429043: Merge 106347 - Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM even… (Closed)

Created:
8 years, 10 months ago by pfeldman
Modified:
8 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 106347 - Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names. https://bugs.webkit.org/show_bug.cgi?id=77409 Reviewed by Yury Semikhatsky. * inspector/Inspector.json: * inspector/InspectorDOMDebuggerAgent.cpp: (WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint): (WebCore): (WebCore::InspectorDOMDebuggerAgent::setInstrumentationBreakpoint): (WebCore::InspectorDOMDebuggerAgent::setBreakpoint): (WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorDOMDebuggerAgent::removeInstrumentationBreakpoint): (WebCore::InspectorDOMDebuggerAgent::removeBreakpoint): (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded): * inspector/InspectorDOMDebuggerAgent.h: (InspectorDOMDebuggerAgent): * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didInstallTimerImpl): (WebCore::InspectorInstrumentation::didRemoveTimerImpl): (WebCore::InspectorInstrumentation::willHandleEventImpl): (WebCore::InspectorInstrumentation::willFireTimerImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded): * inspector/InspectorInstrumentation.h: (InspectorInstrumentation): * inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint): TBR=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=108457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -19 lines) Patch
M Source/WebCore/inspector/Inspector.json View 2 chunks +17 lines, -1 line 0 comments Download
M Source/WebCore/inspector/InspectorDOMDebuggerAgent.h View 3 chunks +5 lines, -1 line 0 comments Download
M Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp View 5 chunks +26 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorInstrumentation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js View 5 chunks +23 lines, -14 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pfeldman
8 years, 10 months ago (2012-02-22 08:47:31 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698