Issue 9429008: Fixed Object.getOwnPropertyDescriptor(string, index) to return descriptor's enumerable property as …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9429008: Fixed Object.getOwnPropertyDescriptor(string, index) to return descriptor's enumerable property as … (Closed)

Created:
8 years, 10 months ago by ioseb

Modified:
8 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Michael Starzinger, rossberg

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Fixed Object.getOwnPropertyDescriptor(string, index) to return descriptor's enumerable property as true. Now implementation matches results found in WebKit and FF. Changed assertFalse() to assertTrue() in corresponding test. ES5 description(step 9): http://es5.github.com/#x15.5.5.2 Original issue description: http://code.google.com/p/v8/issues/detail?id=862 Contributed by ioseb.dzmanashvili@gmail.com

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -2 lines)			Patch
M	AUTHORS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/get-own-property-descriptor.js	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Michael Starzinger

LGTM. Landed as https://chromiumcodereview.appspot.com/9447053/.

8 years, 10 months ago (2012-02-24 11:59:00 UTC) #4

ioseb

8 years, 10 months ago (2012-02-24 12:59:00 UTC) #5

On 2012/02/24 11:59:00, Michael Starzinger wrote:
> LGTM. Landed as https://chromiumcodereview.appspot.com/9447053/.

Thank you!