Issue 9429003: Accurate selection change event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9429003: Accurate selection change event. (Closed)

Created:
8 years, 10 months ago by SeRya

Modified:
8 years, 10 months ago

Reviewers:
arv (Not doing code reviews), dgozman

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Accurate selection change event. List triggers selection change event when the user clicks on already selected item. Click on an unselected event trigger 2 events. It causes user-ovservable updates of preview images in the file manager. Also it's waste of CPU power. BUG=None TEST=Manual test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122999

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -14 lines)			Patch
	M	chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js	View		1 chunk	+1 line, -4 lines	0 comments	Download
	M	chrome/browser/resources/shared/js/cr/ui/list_selection_model.js	View		2 chunks	+19 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages