src/objects.cc - Issue 9429002: After assignment return right hand side value instead of undefined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 9429002: After assignment return right hand side value instead of undefined (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 8b44eceaf006dc61dd0fda63f456956b88a11e94..2b21278b240373ff48639a50b7d2520933ae7a08 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -1756,7 +1756,7 @@ MaybeObject* JSObject::AddProperty(String* name,

Heap* heap = GetHeap();

if (!map_of_this->is_extensible()) {

if (strict_mode == kNonStrictMode) {

- return heap->undefined_value();

+ return value;

} else {

Handle<Object> args[1] = {Handle<String>(name)};

return heap->isolate()->Throw(

« no previous file with comments | « no previous file | test/mjsunit/object-prevent-extensions.js » ('j') | no next file with comments »