Issue 9428046: Remove histograms from printing/emf_win.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9428046: Remove histograms from printing/emf_win.cc. (Closed)

Created:
8 years, 10 months ago by Lei Zhang

Modified:
8 years, 10 months ago

Reviewers:
vandebo (ex-Chrome), sanjeevr

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove histograms from printing/emf_win.cc. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123185

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -10 lines)			Patch
	M	printing/emf_win.cc	View		3 chunks	+1 line, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

This was never hooked up properly internally, and I'm not sure if anyone cares about ...

8 years, 10 months ago (2012-02-22 20:10:31 UTC) #1

sanjeevr

LGTM. These metrics were put in a long time ago when we were forced to ...

8 years, 10 months ago (2012-02-22 21:16:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9428046/1

8 years, 10 months ago (2012-02-22 21:23:47 UTC) #4

commit-bot: I haz the power

8 years, 10 months ago (2012-02-23 01:51:43 UTC) #5

Try job failure for 9428046-1 (retry) on win_rel for steps "unit_tests,
browser_tests, ui_tests".
It's a second try, previously, steps "unit_tests, browser_tests, ui_tests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages