Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 9428027: Fix compilation with MinGW-w64. (Closed)

Created:
8 years, 10 months ago by Yang
Modified:
8 years, 10 months ago
Reviewers:
net147, Net147
CC:
v8-dev
Visibility:
Public.

Description

Fix compilation with MinGW-w64. BUG=v8:1943 TEST= Committed: https://code.google.com/p/v8/source/detail?r=10793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M SConstruct View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-win32.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M src/win32-headers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/cpu-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
Please confirm that this patch indeed fixes compilation on MinGW-w64.
8 years, 10 months ago (2012-02-22 10:21:19 UTC) #1
Net147
8 years, 10 months ago (2012-02-22 11:50:12 UTC) #2
lgtm

Looks good to me and compiles fine.

Powered by Google App Engine
This is Rietveld 408576698