chrome/browser/ui/web_applications/web_app_ui.cc - Issue 9428025: Add support for multiple icon sizes for Mac platform apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/web_applications/web_app_ui.cc

Issue 9428025: Add support for multiple icon sizes for Mac platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review comments Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/web_applications/web_app_ui.cc

diff --git a/chrome/browser/ui/web_applications/web_app_ui.cc b/chrome/browser/ui/web_applications/web_app_ui.cc

index 1d3103a6e6e9c768b7d29bc971be01138a9d87a0..68441549c3e57d4c9d9451b605e30b09ef23566a 100644

--- a/chrome/browser/ui/web_applications/web_app_ui.cc

+++ b/chrome/browser/ui/web_applications/web_app_ui.cc

@@ -309,7 +309,8 @@ void GetShortcutInfoForTab(TabContentsWrapper* tab_contents_wrapper,

web_contents->GetTitle()) :

app_info.title;

info->description = app_info.description;

- info->favicon = tab_contents_wrapper->favicon_tab_helper()->GetFavicon();

+ info->favicon = gfx::Image(

+ new SkBitmap(tab_contents_wrapper->favicon_tab_helper()->GetFavicon()));

Robert Sesek 2012/02/29 15:13:37 The |new SkBitmap| is no longer needed.

sail 2012/02/29 19:45:16 Done.

}

void UpdateShortcutForTabContents(TabContentsWrapper* tab_contents) {