Issue 9428001: Remove redundant statements in NewFunctionFromSharedFunctionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9428001: Remove redundant statements in NewFunctionFromSharedFunctionInfo. (Closed)

Created:
8 years, 10 months ago by ulan

Modified:
8 years, 10 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove redundant statements in NewFunctionFromSharedFunctionInfo. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=10780

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	src/factory.cc	View		1 chunk	+0 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ulan

Please take a look. http://codereview.chromium.org/9428001/diff/1/src/factory.cc File src/factory.cc (left): http://codereview.chromium.org/9428001/diff/1/src/factory.cc#oldcode553 src/factory.cc:553: result->set_next_function_link(isolate()->heap()->undefined_value()); Heap::InitializeFunction sets these fields.

8 years, 10 months ago (2012-02-21 12:51:13 UTC) #1

lgtm

Expand Messages | Collapse Messages