Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 9426032: Fix RegExp white-space character class to match BOMs. (Closed)

Created:
8 years, 10 months ago by Michael Starzinger
Modified:
8 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix RegExp white-space character class to match BOMs. R=rossberg@chromium.org TEST=test262/S15.10.2.12_A?_T1,mjsunit/regexp Committed: https://code.google.com/p/v8/source/detail?r=10770

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comment by Lasse and Andreas. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -25 lines) Patch
M src/jsregexp.cc View 1 1 chunk +14 lines, -16 lines 0 comments Download
M test/mjsunit/regexp.js View 1 chunk +11 lines, -0 lines 0 comments Download
M test/sputnik/sputnik.status View 1 1 chunk +7 lines, -5 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Starzinger
8 years, 10 months ago (2012-02-20 12:02:17 UTC) #1
Michael Starzinger
This is consistent with recent JSC, but recent SM still is non-ES5 in that regard.
8 years, 10 months ago (2012-02-20 12:10:07 UTC) #2
Lasse Reichstein Nielsen
https://chromiumcodereview.appspot.com/9426032/diff/1/test/sputnik/sputnik.status File test/sputnik/sputnik.status (right): https://chromiumcodereview.appspot.com/9426032/diff/1/test/sputnik/sputnik.status#newcode134 test/sputnik/sputnik.status:134: S15.10.2.12_A2_T1: PASS || FAIL_OK If you can, make it ...
8 years, 10 months ago (2012-02-20 13:55:30 UTC) #3
rossberg
http://codereview.chromium.org/9426032/diff/1/src/jsregexp.cc File src/jsregexp.cc (right): http://codereview.chromium.org/9426032/diff/1/src/jsregexp.cc#newcode3600 src/jsregexp.cc:3600: static const int kSpaceRangeCount = 22; Not your code, ...
8 years, 10 months ago (2012-02-20 16:03:19 UTC) #4
Michael Starzinger
PTAL. Added new patch set. https://chromiumcodereview.appspot.com/9426032/diff/1/src/jsregexp.cc File src/jsregexp.cc (right): https://chromiumcodereview.appspot.com/9426032/diff/1/src/jsregexp.cc#newcode3600 src/jsregexp.cc:3600: static const int kSpaceRangeCount ...
8 years, 10 months ago (2012-02-20 16:34:00 UTC) #5
rossberg
8 years, 10 months ago (2012-02-20 16:52:43 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698