Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9426001: Retry DRT if we crash with core dump. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 4341)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -213,9 +213,10 @@
// If the browser test failed, it may have been because DumpRenderTree
// and the virtual framebuffer X server didn't hook up.
for (String line in stderr) {
- if (line.contains('Gtk-WARNING **: cannot open display: :99')) {
- // If we get the X server error, return the expected value
- // We cannot restart the test from here. Issue dart:1135 is filed.
+ if (line.contains('Gtk-WARNING **: cannot open display: :99') ||
+ line.contains('Failed to run command. return code=1')) {
+ // If we get the X server error, or DRT crashes with a core dump, retry
+ // the test.
requestRetry = true;
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698