Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 9425061: On ia32 LFunctionLiteral instruction should get context from esi register instead of stack slot. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4443 matching lines...) Expand 10 before | Expand all | Expand 10 after
4454 ASSERT(ToRegister(instr->context()).is(esi)); 4454 ASSERT(ToRegister(instr->context()).is(esi));
4455 // Use the fast case closure allocation code that allocates in new 4455 // Use the fast case closure allocation code that allocates in new
4456 // space for nested functions that don't need literals cloning. 4456 // space for nested functions that don't need literals cloning.
4457 Handle<SharedFunctionInfo> shared_info = instr->shared_info(); 4457 Handle<SharedFunctionInfo> shared_info = instr->shared_info();
4458 bool pretenure = instr->hydrogen()->pretenure(); 4458 bool pretenure = instr->hydrogen()->pretenure();
4459 if (!pretenure && shared_info->num_literals() == 0) { 4459 if (!pretenure && shared_info->num_literals() == 0) {
4460 FastNewClosureStub stub(shared_info->language_mode()); 4460 FastNewClosureStub stub(shared_info->language_mode());
4461 __ push(Immediate(shared_info)); 4461 __ push(Immediate(shared_info));
4462 CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr); 4462 CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr);
4463 } else { 4463 } else {
4464 __ push(Operand(ebp, StandardFrameConstants::kContextOffset)); 4464 __ push(esi);
4465 __ push(Immediate(shared_info)); 4465 __ push(Immediate(shared_info));
4466 __ push(Immediate(pretenure 4466 __ push(Immediate(pretenure
4467 ? factory()->true_value() 4467 ? factory()->true_value()
4468 : factory()->false_value())); 4468 : factory()->false_value()));
4469 CallRuntime(Runtime::kNewClosure, 3, instr); 4469 CallRuntime(Runtime::kNewClosure, 3, instr);
4470 } 4470 }
4471 } 4471 }
4472 4472
4473 4473
4474 void LCodeGen::DoTypeof(LTypeof* instr) { 4474 void LCodeGen::DoTypeof(LTypeof* instr) {
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
4727 this, pointers, Safepoint::kLazyDeopt); 4727 this, pointers, Safepoint::kLazyDeopt);
4728 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator); 4728 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator);
4729 } 4729 }
4730 4730
4731 4731
4732 #undef __ 4732 #undef __
4733 4733
4734 } } // namespace v8::internal 4734 } } // namespace v8::internal
4735 4735
4736 #endif // V8_TARGET_ARCH_IA32 4736 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698