Implement Math API.

dart/frog/leg/lib/js_helper.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('js_helper');
 
 #import('coreimpl.dart');
 
 /**
   * Returns true if both arguments are numbers.
   * If only the first argument is a number, throws the given message as
   * exception.
   */
 bool checkNumbers(var a, var b, var message) {
   if (a is num) {
     if (b is num) {
       return true;
     } else {
+      checkNull(b);
       throw new IllegalArgumentException(message);
     }
   }
   return false;
 }
 
 
 bool isJSArray(var value) {
   return JS("bool", @"$0.constructor === Array", value);
 }
@@ skipping 357 matching lines @@
   static int getMinutes(int secondsSinceEpoch, bool isUtc) {
     throw 'Primitives.getMinutes is not implemented';
   }
 
   static int getSeconds(int secondsSinceEpoch, bool isUtc) {
     throw 'Primitives.getSeconds is not implemented';
   }
 }
 
 builtin$compareTo$1(a, b) {
+  checkNull(a);
   if (checkNumbers(a, b, 'illegal argument')) {
     if (a < b) {
       return -1;
     } else if (a > b) {
       return 1;
     } else if (a == b) {
       if (a == 0) {
         bool aIsNegative = a.isNegative();
         bool bIsNegative = b.isNegative();
         if (aIsNegative == bIsNegative) return 0;
@@ skipping 480 matching lines @@
 }
 
 builtin$toUpperCase$0(receiver) {
   checkNull(receiver);
   if (receiver is !String) return UNINTERCEPTED(receiver.toUpperCase());
 
   throw new NotImplementedException();
 }
 
 builtin$trim$0(receiver) {
   checkNull(receiver);

[ngeoffray, 2012/02/21 09:39:43]

No need for check null.

   if (receiver is !String) return UNINTERCEPTED(receiver.trim());
 
-  throw new NotImplementedException();
+  return JS('String', @'$0.trim()', receiver);
 }
 
 class MathNatives {
-  static int parseInt(String str) {
-    throw 'MathNatives.parseInt is not implemented';
+  static int parseInt(str) {
+    checkNull(str);

[ngeoffray, 2012/02/21 09:39:43]

No need for check null.

+    if (str is !String) throw new IllegalArgumentException(str);
+    var trimmed = str.trim();
+    if (!JS('bool', @'/^(0[xX])?[+-]?[0-9]+$/.test($0)', trimmed)) {
+      throw new BadNumberFormatException(str);
+    }
+    var ret = JS("num", @"parseInt($0, 10)", str);
+    if (ret.isNaN()) throw new BadNumberFormatException(str);
+    return ret;
   }
 
   static double parseDouble(String str) {
-    throw 'MathNatives.parseDouble is not implemented';
+    checkNull(str);

[ngeoffray, 2012/02/21 09:39:43]

No need for check null.

+    if (str is !String) throw new IllegalArgumentException();
+    var ret = JS("num", @"parseFloat($0)", str);
+    if (ret.isNaN() && str != 'NaN') throw new BadNumberFormatException(str);
+    return ret;
   }
 
   static double sqrt(num value)
     => JS("double", @"Math.sqrt($0)", checkNum(value));
 
   static double sin(num value)
     => JS("double", @"Math.sin($0)", checkNum(value));
 
   static double cos(num value)
     => JS("double", @"Math.cos($0)", checkNum(value));
 
   static double tan(num value)
     => JS("double", @"Math.tan($0)", checkNum(value));
 
   static double acos(num value)
     => JS("double", @"Math.acos($0)", checkNum(value));
 
   static double asin(num value)
     => JS("double", @"Math.asin($0)", checkNum(value));
 
   static double atan(num value)
     => JS("double", @"Math.atan($0)", checkNum(value));
 
   static double atan2(num a, num b)
-    => JS("double", @"Math.atan2($0)", checkNum(value));
+    => JS("double", @"Math.atan2($0, $1)", checkNum(a), checkNum(b));
 
   static double exp(num value)
     => JS("double", @"Math.exp($0)", checkNum(value));
 
   static double log(num value)
     => JS("double", @"Math.log($0)", checkNum(value));
 
   static num pow(num value, num exponent) {
     checkNum(value);
     checkNum(exponent);
     return JS("num", @"Math.pow($0, $1)", value, exponent);
   }
 
-  static double random() => JS("double", "Math.random()");
+  static double random() => JS("double", @"Math.random()");
 }
 
 builtin$hashCode$0(receiver) {
   if (receiver is num) return receiver & 0x1FFFFFFF;
   if (receiver is String) {
     throw new NotImplementedException();
   }
   if (isJSArray(receiver)) {
     throw new NotImplementedException();
   }
   return UNINTERCEPTED(receiver.hashCode());
 }