Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 9425036: make action_dependencies test win32 and c89 friendly (Closed)

Created:
8 years, 10 months ago by scottmg
Modified:
8 years, 9 months ago
Reviewers:
Evan Martin, piman
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

make action_dependencies test win32 and c89 friendly Committed: https://code.google.com/p/gyp/source/detail?r=1216

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M test/ninja/action_dependencies/gyptest-action-dependencies.py View 1 2 3 4 5 3 chunks +13 lines, -5 lines 0 comments Download
M test/ninja/action_dependencies/src/b.c View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
8 years, 10 months ago (2012-02-19 05:50:21 UTC) #1
Evan Martin
LGTM https://chromiumcodereview.appspot.com/9425036/diff/4003/test/ninja/action_dependencies/gyptest-action-dependencies.py File test/ninja/action_dependencies/gyptest-action-dependencies.py (right): https://chromiumcodereview.appspot.com/9425036/diff/4003/test/ninja/action_dependencies/gyptest-action-dependencies.py#newcode30 test/ninja/action_dependencies/gyptest-action-dependencies.py:30: # TODO(cross-compile) normal argument for TODO is who ...
8 years, 10 months ago (2012-02-21 00:55:54 UTC) #2
piman
8 years, 9 months ago (2012-03-06 01:55:52 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698