Remove getters for HTML5 related objects from the ResourceContext interface. Half of them weren't u…

Remove getters for HTML5 related objects from the ResourceContext interface. Half of them weren't used by chrome, so they can be hidden from chrome. The rest were accessed by chrome, but we don't need every embedder to store this data on their ResourceContext implementation. Instead have content associate the data itself to simplify the work for embedders.

BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122790

[jam, 2012-02-20 18:51:15]

or Joi, if you have a chance to look :)

[Jói, 2012-02-20 23:13:48]

LGTM, very nice.

https://chromiumcodereview.appspot.com/9425026/diff/5078/chrome/browser/profi...
File chrome/browser/profiles/profile_impl.cc (right):

https://chromiumcodereview.appspot.com/9425026/diff/5078/chrome/browser/profi...
chrome/browser/profiles/profile_impl.cc:178: appcache::AppCacheService*
appcache_service) {
perhaps DCHECK on this not being NULL since you removed the conditional below

https://chromiumcodereview.appspot.com/9425026/diff/5078/content/browser/brow...
File content/browser/browser_context.cc (left):

https://chromiumcodereview.appspot.com/9425026/diff/5078/content/browser/brow...
content/browser/browser_context.cc:99: // Check first to avoid memory leak in
unittests.
I'm sure you're sure, but would still suggest running valgrind and memcheck
trybots since you're changing this.

https://chromiumcodereview.appspot.com/9425026/diff/5078/content/browser/chro...
File content/browser/chrome_blob_storage_context.h (right):

https://chromiumcodereview.appspot.com/9425026/diff/5078/content/browser/chro...
content/browser/chrome_blob_storage_context.h:30: class CONTENT_EXPORT
ChromeBlobStorageContext
So this is chrome as in "the browser chrome"?  Somewhat unfortunate naming since
this is in content :D

[jam, 2012-02-21 01:20:12]

https://chromiumcodereview.appspot.com/9425026/diff/5078/chrome/browser/profi...
File chrome/browser/profiles/profile_impl.cc (right):

https://chromiumcodereview.appspot.com/9425026/diff/5078/chrome/browser/profi...
chrome/browser/profiles/profile_impl.cc:178: appcache::AppCacheService*
appcache_service) {
On 2012/02/20 23:13:49, Jói wrote:
> perhaps DCHECK on this not being NULL since you removed the conditional below

I'm personally not a fan of DCHECKing that a pointer isn't null before it's
used, since if it's NULL the crash below will be just as good of a signal :)

https://chromiumcodereview.appspot.com/9425026/diff/5078/content/browser/brow...
File content/browser/browser_context.cc (left):

https://chromiumcodereview.appspot.com/9425026/diff/5078/content/browser/brow...
content/browser/browser_context.cc:99: // Check first to avoid memory leak in
unittests.
On 2012/02/20 23:13:49, Jói wrote:
> I'm sure you're sure, but would still suggest running valgrind and memcheck
> trybots since you're changing this.

oops, thanks for catching this! This change got lost when these lines got
reverted and added, and the change didn't carry over because of a conflict.
added back. ditto on the bottom of the file. i should have reviewed this more
carefully after the conflict (oh the joy of reverts ;) ).

good idea re running this through memory bots either way, will do

https://chromiumcodereview.appspot.com/9425026/diff/5078/content/browser/chro...
File content/browser/chrome_blob_storage_context.h (right):

https://chromiumcodereview.appspot.com/9425026/diff/5078/content/browser/chro...
content/browser/chrome_blob_storage_context.h:30: class CONTENT_EXPORT
ChromeBlobStorageContext
On 2012/02/20 23:13:49, Jói wrote:
> So this is chrome as in "the browser chrome"?  Somewhat unfortunate naming
since
> this is in content :D

it was called chrome before we had the content split, to differentiate it from
AppCacheService in in the src/webkit layer. I have a todo on my tasklist to
rename this and ChromeBlobStorageContext :)

[jam, 2012-02-21 04:38:28]

btw it doesn't show up here, but i had run them through the memory bots, fixed
the issues and verified locally on my linux box. but i forgot to upload before
commit