Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 9424038: Merge 108100 - 2012-02-17 Nate Chapin <> (Closed)

8 years, 10 months ago by Nate Chapin
8 years, 10 months ago
Nate Chapin
Base URL:


Merge 108100 - 2012-02-17 Nate Chapin <>; [Chromium mac] Cursors and background images disappear. The issue occurs because a CachedImage sees that it has no clients and decide it is safe to purge its m_data buffer. However, StyleCachedImage is holding a CachedResourceHandle to the CachedImage, and it can still add a client later. If it does so, the CachedImage says everything is loaded but has no data. Reviewed by Adam Barth. No new tests, since the known repros have resisted reduction. Tested manually with, and a couple of other sites. * rendering/style/StyleCachedImage.cpp: * rendering/style/StyleCachedImage.h: Ensure the underlying CachedImage has a client for the lifetime of the StyleCachedImage and doesn't purge its buffer. Call addClient(this) in the constructor and removeClient(this) in the destructor, then ignore all cache callbacks. Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M Source/WebCore/rendering/style/StyleCachedImage.h View 2 chunks +6 lines, -8 lines 0 comments Download
M Source/WebCore/rendering/style/StyleCachedImage.cpp View 1 chunk +12 lines, -1 line 0 comments Download


Total messages: 1 (0 generated)
Nate Chapin
8 years, 10 months ago (2012-02-20 18:48:49 UTC) #1


Powered by Google App Engine
This is Rietveld 408576698