Issue 9424030: Fix test/product broken at r1211

Issue 9424030: Fix test/product broken at r1211 (Closed)

Created:
8 years, 10 months ago by scottmg

Modified:
8 years, 10 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix test/product broken at r1211 (product_extension explicitly specified lost its leading .) TBR=thakis Committed: https://code.google.com/p/gyp/source/detail?r=1214

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	pylib/gyp/generator/ninja.py	View		1 chunk	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

https://chromiumcodereview.appspot.com/9424030/diff/1/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (left): https://chromiumcodereview.appspot.com/9424030/diff/1/pylib/gyp/generator/ninja.py#oldcode856 pylib/gyp/generator/ninja.py:856: DEFAULT_EXTENSION.get(type, '')) Maybe extension = '.' + spec.get('product_extension', DEFAULT_EXTENSION.get(type, ...

8 years, 10 months ago (2012-02-20 05:31:19 UTC) #2

scottmg

On 2012/02/20 05:31:19, Nico wrote: > https://chromiumcodereview.appspot.com/9424030/diff/1/pylib/gyp/generator/ninja.py > File pylib/gyp/generator/ninja.py (left): > > https://chromiumcodereview.appspot.com/9424030/diff/1/pylib/gyp/generator/ninja.py#oldcode856 > ...

8 years, 10 months ago (2012-02-20 05:32:40 UTC) #3

scottmg

8 years, 10 months ago (2012-02-20 05:42:29 UTC) #4

On 2012/02/20 05:32:40, scottmg wrote:
> On 2012/02/20 05:31:19, Nico wrote:
> >
>
https://chromiumcodereview.appspot.com/9424030/diff/1/pylib/gyp/generator/nin...
> > File pylib/gyp/generator/ninja.py (left):
> > 
> >
>
https://chromiumcodereview.appspot.com/9424030/diff/1/pylib/gyp/generator/nin...
> > pylib/gyp/generator/ninja.py:856: DEFAULT_EXTENSION.get(type, ''))
> > Maybe
> > 
> > extension = '.' + spec.get('product_extension',
> >                                  DEFAULT_EXTENSION.get(type, '.')[1:])
> > 
> > ?
> 
> Oops, sorry, just committed to fix, didn't think you'd be reviewing. Will
change
> per your suggestion.

Oh, that adds a . when there's supposed to be no extension. Hmm, seems like it
has to have an if so may as well make it the obvious one?

Expand Messages | Collapse Messages