Force browser action icon size to always be 19px

chrome/browser/extensions/browser_action_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 78 matching lines @@
       L"    window.domAutomationController.send(true)}}, 100)",
       &result));
   ASSERT_TRUE(result);
 }
 
 IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, DynamicBrowserAction) {
   ASSERT_TRUE(RunExtensionTest("browser_action/no_icon")) << message_;
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_TRUE(extension) << message_;
 
-  // Test that there is a browser action in the toolbar and that it has no icon.
+  // Test that there is a browser action in the toolbar.
   ASSERT_EQ(1, GetBrowserActionsBar().NumberOfBrowserActions());
-  EXPECT_FALSE(GetBrowserActionsBar().HasIcon(0));
+
+  // Get the generation ID of the original SkBitmap. This will be the default
+  // browser action icon.
+  uint32_t prev_id = extension->browser_action()->GetIcon(0).getGenerationID();
 
   // Tell the extension to update the icon using setIcon({imageData:...}).
   ResultCatcher catcher;
   ui_test_utils::NavigateToURL(browser(),
       GURL(extension->GetResourceURL("update.html")));
   ASSERT_TRUE(catcher.GetNextResult());
 
   // Test that we received the changes.
   EXPECT_TRUE(GetBrowserActionsBar().HasIcon(0));
 
+  // Test to make sure the images are different.
+  EXPECT_TRUE(prev_id !=
+      extension->browser_action()->GetIcon(0).getGenerationID());
+
+  // Reset prev_id for next test.

[Devlin, 2012/02/25 18:41:00]

Please use proper grammar in comments.

[cduvall, 2012/02/25 19:23:06]

Done.

+  prev_id = extension->browser_action()->GetIcon(0).getGenerationID();
+
   // Tell the extension to update using setIcon({path:...});

[Devlin, 2012/02/25 18:41:00]

I know it's not your code, but you should change the ; to a . in this comment
(if you keep the line - see my comment on 130).  It makes it match the style on
106, and it also makes it exceedingly clear that this is a comment, even if you
only skim the right half of the line - code ends in semicolons; comments end in
periods.

[cduvall, 2012/02/25 19:23:06]

Done.

   ui_test_utils::NavigateToURL(browser(),
       GURL(extension->GetResourceURL("update2.html")));
   ASSERT_TRUE(catcher.GetNextResult());
 
   // Test that we received the changes.
   EXPECT_TRUE(GetBrowserActionsBar().HasIcon(0));
 
+  // Test to make sure the images are different.

[Devlin, 2012/02/25 18:41:00]

The second set of comments seems superfluous, and there's a policy of not having
"useless" comments.  Since these are all described in detail in the process
above, I might consider changing the comment on line 119 to read something like
"Reset prev_id for the next test and repeat the process using
setIcon({path:...})."  You could then remove comments on lines 122, 127, and
130.  But if you think that it's more clear like this, then that's fine.

[cduvall, 2012/02/25 19:23:06]

Done.

+  EXPECT_TRUE(prev_id !=
+      extension->browser_action()->GetIcon(0).getGenerationID());
+
   // TODO(aa): Would be nice here to actually compare that the pixels change.

[Devlin, 2012/02/25 18:41:00]

Isn't this what we are doing now?  It's safe to remove the TODO.

[cduvall, 2012/02/25 19:23:06]

Done.

 }
 
 // This test is flaky as per http://crbug.com/74557.
 IN_PROC_BROWSER_TEST_F(BrowserActionApiTest,
                        DISABLED_TabSpecificBrowserActionState) {
   ASSERT_TRUE(RunExtensionTest("browser_action/tab_specific_state")) <<
       message_;
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_TRUE(extension) << message_;
 
@@ skipping 270 matching lines @@
       BrowserActionExecuted(
           browser()->profile(), action->extension_id(), browser());
 
   // It can take a moment for the background page to actually get destroyed
   // so we wait for the notification before checking that it's really gone
   // and the badge text has been set.
   host_destroyed_observer.Wait();
   ASSERT_FALSE(manager->GetBackgroundHostForExtension(extension->id()));
   ASSERT_EQ("X", action->GetBadgeText(ExtensionAction::kDefaultTabId));
 }