Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2267)

Unified Diff: chrome/app/chrome_main_app_mode_mac.mm

Issue 9423048: Add user data dir field to Mac platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_main_app_mode_mac.mm
diff --git a/chrome/app/chrome_main_app_mode_mac.mm b/chrome/app/chrome_main_app_mode_mac.mm
index 8db1c30e8d2e3248427ac07b571354efdd6ee0ba..9d897d61ca6e6dc6e48e184e7fcefe7cd9898b3a 100644
--- a/chrome/app/chrome_main_app_mode_mac.mm
+++ b/chrome/app/chrome_main_app_mode_mac.mm
@@ -51,10 +51,10 @@ int ChromeAppModeStart(const app_mode::ChromeAppModeInfo* info) {
// TODO(viettrungluu): do something intelligent with data
// return ChromeMain(info->argc, info->argv);
// For now, a cheesy hack instead.
- RAW_CHECK(info->app_mode_url.size());
- std::string argv1(std::string("--app=") + info->app_mode_url);
RAW_CHECK(info->app_mode_id.size());
- std::string argv2(std::string("--user-data-dir=/tmp/") + info->app_mode_id);
+ std::string argv1(std::string("--app-id=") + info->app_mode_id);
+ std::string argv2(
+ std::string("--user-data-dir=") + info->user_data_dir.value());
char* argv[] = { info->argv[0],
const_cast<char*>(argv1.c_str()),
const_cast<char*>(argv2.c_str()) };

Powered by Google App Engine
This is Rietveld 408576698