Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: chrome/browser/web_applications/web_app_mac.h

Issue 9423048: Add user data dir field to Mac platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_applications/web_app_mac.h
diff --git a/chrome/browser/web_applications/web_app_mac.h b/chrome/browser/web_applications/web_app_mac.h
index ad244aa3947d199707e188db996eca5999357c53..0add11a3c8467665141dee5b75bace3b44a80510 100644
--- a/chrome/browser/web_applications/web_app_mac.h
+++ b/chrome/browser/web_applications/web_app_mac.h
@@ -22,7 +22,9 @@ class WebAppShortcutCreator {
public:
// Creates a new shortcut based on information in |shortcut_info|.
// |chrome_bundle_id| is the CFBundleIdentifier of the Chrome browser bundle.
+ // The shortcut store its data directory in |web_app_path|.
jeremy 2012/02/21 12:17:59 How about: The shortcut will store data in it's ow
sail 2012/02/22 22:10:08 This should be data directory. I changed the varia
explicit WebAppShortcutCreator(
+ const FilePath& web_app_path,
jeremy 2012/02/21 12:17:59 I'd call this: app_profile_directory_path or app_l
sail 2012/02/22 22:10:08 Same as above.
const ShellIntegration::ShortcutInfo& shortcut_info,
const string16& chrome_bundle_id);
virtual ~WebAppShortcutCreator();
@@ -56,6 +58,10 @@ class WebAppShortcutCreator {
virtual void RevealGeneratedBundleInFinder(
const FilePath& generated_bundle) const;
+ // Path to the app's data directory. For example:
+ // ~/Library/Application Support/Chromium/Default/Web Applications/_crx_abc/
+ FilePath web_app_path_;
+
// Information about the app.
ShellIntegration::ShortcutInfo info_;

Powered by Google App Engine
This is Rietveld 408576698