Add user data dir field to Mac platform apps

chrome/app/app_mode_loader_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // On Mac, shortcuts can't have command-line arguments. Instead, produce small
 // app bundles which locate the Chromium framework and load it, passing the
 // appropriate data. This is the code for such an app bundle. It should be kept
 // minimal and do as little work as possible (with as much work done on
 // framework side as possible).
 
@@ skipping 74 matching lines @@
   info->app_mode_id = SysNSStringToUTF8(
       [info_plist objectForKey:app_mode::kCrAppModeShortcutIDKey]);
   CHECK(info->app_mode_id.size()) << "couldn't get app shortcut ID";
 
   info->app_mode_name = SysNSStringToUTF16(
       [info_plist objectForKey:app_mode::kCrAppModeShortcutNameKey]);
 
   info->app_mode_url = SysNSStringToUTF8(
       [info_plist objectForKey:app_mode::kCrAppModeShortcutURLKey]);
 
+  info->user_data_dir = base::mac::NSStringToFilePath(

[jeremy, 2012/02/23 13:30:54]

What makes this a "user data dir" rather than just a "data dir"?

[sail, 2012/02/23 18:31:17]

Done.

user_data_dir is the correct name. I changed the references to "data dir" to
"user data dir".

+      [info_plist objectForKey:app_mode::kCrAppModeUserDataDirKey]);
+
   // Open the framework.
   *cr_dylib = dlopen(framework_shlib_path.value().c_str(), RTLD_LAZY);
   CHECK(cr_dylib) << "couldn't load framework: " << dlerror();
 }
 
 } // namespace
 
 __attribute__((visibility("default")))
 int main(int argc, char** argv) {
   app_mode::ChromeAppModeInfo info;
@@ skipping 10 matching lines @@
 
   typedef int (*StartFun)(const app_mode::ChromeAppModeInfo*);
   StartFun ChromeAppModeStart = (StartFun)dlsym(cr_dylib, "ChromeAppModeStart");
   CHECK(ChromeAppModeStart) << "couldn't get entry point";
 
   // Exit instead of returning to avoid the the removal of |main()| from stack
   // backtraces under tail call optimization.
   int rv = ChromeAppModeStart(&info);
   exit(rv);
 }