Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: dart/frog/leg/ssa/builder.dart

Issue 9423040: Fix crash in SSA builder for receiver-less calls. Not sure this is correct. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/lib/js_helper.dart ('k') | dart/tests/co19/co19-leg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/ssa/builder.dart
diff --git a/dart/frog/leg/ssa/builder.dart b/dart/frog/leg/ssa/builder.dart
index 40c6d540a7142671fb5e556e4eca931f868a6442..b8bf2f5c3633cc92b0c35e6f46e733557b6316e8 100644
--- a/dart/frog/leg/ssa/builder.dart
+++ b/dart/frog/leg/ssa/builder.dart
@@ -1504,8 +1504,10 @@ class SsaBuilder implements Visitor {
HStatic target = new HStatic(interceptor);
add(target);
inputs.add(target);
- visit(node.receiver);
- inputs.add(pop());
+ if (node.receiver !== null) {
+ visit(node.receiver);
+ inputs.add(pop());
+ }
addGenericSendArgumentsToList(node.arguments, inputs);
push(new HInvokeInterceptor(selector, dartMethodName, false, inputs));
return;
« no previous file with comments | « dart/frog/leg/lib/js_helper.dart ('k') | dart/tests/co19/co19-leg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698