mac ninja&make: Filter out useless 'This view is clipping its content' message.

pylib/gyp/mac_tool.py

 #!/usr/bin/env python
 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility functions to perform Xcode-style build steps.
 
 These functions are executed via gyp-mac-tool when using the Makefile generator.
 """
 
@@ skipping 33 matching lines @@
   def ExecCopyBundleResource(self, source, dest):
     """Copies a resource file to the bundle/Resources directory, performing any
     necessary compilation on each resource."""
     extension = os.path.splitext(source)[1].lower()
     if os.path.isdir(source):
       # Copy tree.
       if os.path.exists(dest):
         shutil.rmtree(dest)
       shutil.copytree(source, dest)
     elif extension == '.xib':
-      self._CopyXIBFile(source, dest)
+      return self._CopyXIBFile(source, dest)
     elif extension == '.strings':
       self._CopyStringsFile(source, dest)
     # TODO: Given that files with arbitrary extensions can be copied to the
     # bundle, we will want to get rid of this whitelist eventually.
     elif extension in [
         '.icns', '.manifest', '.pak', '.pdf', '.png', '.sb', '.sh',
         '.ttf', '.sdef']:
       shutil.copyfile(source, dest)
     else:
       raise NotImplementedError(
           "Don't know how to copy bundle resources of type %s while copying "
           "%s to %s)" % (extension, source, dest))
 
   def _CopyXIBFile(self, source, dest):
     """Compiles a XIB file with ibtool into a binary plist in the bundle."""
     args = ['/Developer/usr/bin/ibtool', '--errors', '--warnings',
         '--notices', '--output-format', 'human-readable-text', '--compile',
         dest, source]
-    subprocess.call(args)
+    ibtool_section_re = re.compile(r'/\*.*\*/')
+    ibtool_re = re.compile(r'.*note:.*is clipping its content')
+    ibtoolout = subprocess.Popen(args, stdout=subprocess.PIPE)
+    current_section_header = None
+    for line in ibtoolout.stdout:
+      if ibtool_section_re.match(line):
+        current_section_header = line
+      elif not ibtool_re.match(line):
+        if current_section_header:
+          sys.stdout.write(current_section_header)
+          current_section_header = None

[Robert Sesek, 2012/02/21 15:53:28]

Can there be multiple lines of output under the same section header that you'd
want to filter?

[Nico, 2012/02/21 16:23:46]

Yes:

/* com.apple.ibtool.document.notices */
/b/build/slave/Mac/build/src/chrome/app/nibs/SpeechInputBubble.xib:838: note:
This view is clipping its content.
This view is clipping its content.
/b/build/slave/Mac/build/src/chrome/app/nibs/SpeechInputBubble.xib:811: note:
This view is clipping its content.
This view is clipping its content.
/b/build/slave/Mac/build/src/chrome/app/nibs/SpeechInputBubble.xib:842: note:
This view is clipping its content.
This view is clipping its content.
/b/build/slave/Mac/build/src/chrome/app/nibs/SpeechInputBubble.xib:813: note:
This view is clipping its content.
This view is clipping its content.



What my code is trying to do is delay printing the section header until there's
been one line of unfiltered output in that section.

+        sys.stdout.write(line)
+    return ibtoolout.returncode
 
   def _CopyStringsFile(self, source, dest):
     """Copies a .strings file using iconv to reconvert the input into UTF-16."""
     input_code = self._DetectInputEncoding(source) or "UTF-8"
     fp = open(dest, 'w')
     args = ['/usr/bin/iconv', '--from-code', input_code, '--to-code',
         'UTF-16', source]
     subprocess.call(args, stdout=fp)
     fp.close()
 
@@ skipping 111 matching lines @@
   def _Relink(self, dest, link):
     """Creates a symlink to |dest| named |link|. If |link| already exists,
     it is overwritten."""
     if os.path.lexists(link):
       os.remove(link)
     os.symlink(dest, link)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))