Issue 9422025: Fix copy steps for win32 ninja

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9422025: Fix copy steps for win32 ninja (Closed)

Created:
8 years, 10 months ago by scottmg

Modified:
8 years, 10 months ago

Reviewers:
Nico, Evan Martin

CC:
gyp-developer_googlegroups.com, Evan Martin

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

- Another normpath (slightly concerned about this one for other platforms? but it makes the build files a lot more consistent on Windows) - Fix copy rule for windows (mklink directory if file fails) Committed: https://code.google.com/p/gyp/source/detail?r=1213

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	pylib/gyp/generator/ninja.py	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

https://chromiumcodereview.appspot.com/9422025/diff/1002/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): https://chromiumcodereview.appspot.com/9422025/diff/1002/pylib/gyp/generator/ninja.py#newcode205 pylib/gyp/generator/ninja.py:205: path = path.replace(PRODUCT_DIR + '\\', '') The two above ...

8 years, 10 months ago (2012-02-20 22:18:18 UTC) #3

scottmg

8 years, 10 months ago (2012-02-21 02:08:17 UTC) #5

On 2012/02/21 01:11:27, Nico wrote:
> According to go/gypbot, this broke ninja tests on mac.

Looks like some actions have an empty "" in their actions: [] as the first
argument. normpath converts that to '.' which happens to work for scripts but
it's a bit weird anyway. (I'm actually not sure that that's the failure on Mac,
but I'll revert for now and see if there's a better place to do the normalize.)

Expand Messages | Collapse Messages