chrome/browser/extensions/api/declarative/declarative_apitest.cc - Issue 9422003: Migrate Declarative API bindings to new JSON objects generated by JSON compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/declarative_apitest.cc

Issue 9422003: Migrate Declarative API bindings to new JSON objects generated by JSON compiler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments and fixed some stuff Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative/declarative_api.cc ('K') | « chrome/browser/extensions/api/declarative/declarative_api_constants.cc ('k') | chrome/browser/extensions/api/declarative/initializing_rules_registry.h » ('j') | chrome/browser/extensions/api/declarative/rules_registry.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/declarative_apitest.cc

diff --git a/chrome/browser/extensions/api/declarative/declarative_apitest.cc b/chrome/browser/extensions/api/declarative/declarative_apitest.cc

index eb6a248edf87031a372565017dd12164968f5feb..5fd9ce30a72bff043f63c8422ebe76e2f0b35eab 100644

--- a/chrome/browser/extensions/api/declarative/declarative_apitest.cc

+++ b/chrome/browser/extensions/api/declarative/declarative_apitest.cc

@@ -54,7 +54,7 @@ IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, DeclarativeApi) {

UnloadExtension(extension_id);

std::vector<std::string> rule_identifiers; // Empty to get all rules.

- std::vector<DictionaryValue*> known_rules;

+ std::vector<linked_ptr<RulesRegistry::Rule> > known_rules;

test_rules_registry_->GetRules(extension_id,

rule_identifiers,

&known_rules);