Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 9422001: Make 'module' a context-sensitive keyword. (Closed)

Created:
8 years, 10 months ago by rossberg
Modified:
8 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make 'module' a context-sensitive keyword. Baseline: http://codereview.chromium.org/9401008/ R=lrn@chromium.org,mstarzinger@chromium.org BUG=v8:1957 TEST=mjsunit/harmony/module-parsing Committed: https://code.google.com/p/v8/source/detail?r=10832

Patch Set 1 #

Patch Set 2 : Added missing CHECK_OK; rebased. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -17 lines) Patch
M src/heap.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.cc View 1 3 chunks +29 lines, -7 lines 2 comments Download
M src/scanner.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/token.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/harmony/module-parsing.js View 1 chunk +16 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
8 years, 10 months ago (2012-02-17 16:30:40 UTC) #1
Michael Starzinger
LGTM. https://chromiumcodereview.appspot.com/9422001/diff/5001/src/parser.cc File src/parser.cc (right): https://chromiumcodereview.appspot.com/9422001/diff/5001/src/parser.cc#newcode2196 src/parser.cc:2196: scanner().literal_contains_escapes()) { A seven line condition. That's an ...
8 years, 10 months ago (2012-02-24 12:19:16 UTC) #2
Michael Starzinger
8 years, 10 months ago (2012-02-24 12:31:05 UTC) #3
https://chromiumcodereview.appspot.com/9422001/diff/5001/src/parser.cc
File src/parser.cc (right):

https://chromiumcodereview.appspot.com/9422001/diff/5001/src/parser.cc#newcod...
src/parser.cc:1207: !scanner().literal_contains_escapes()) {
As discussed offline ignoring escapes here is consistent with the rest of our
code-base. But looking at the spec more closely we came to the conclusion that
escapes should be allowed in keywords as well.

Powered by Google App Engine
This is Rietveld 408576698