Issue 9421032: Add a missing check for a failure result.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9421032: Add a missing check for a failure result. (Closed)

Created:
8 years, 10 months ago by fschneider

Modified:
8 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Add a missing check for a failure result. Function calls that may return a failure must use the result. Enforce this by adding missing MUST_USE_RESULT to their declarations. Committed: https://code.google.com/p/v8/source/detail?r=10748

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -59 lines)			Patch
M	src/bootstrapper.cc	View	5 chunks	+8 lines, -4 lines	0 comments	Download
M	src/elements.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/objects.h	View	21 chunks	+67 lines, -54 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages