Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 9421027: Fix typo in Flash::IsAvailable. I got a compiler error when building for heapcheck. No idea why thi… (Closed)

Created:
8 years, 10 months ago by jam
Modified:
8 years, 10 months ago
Reviewers:
brettw, viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Fix typo in Flash::IsAvailable. I got a compiler error when building for heapcheck. No idea why this isn't caught by compilers. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ppapi/cpp/private/flash.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
8 years, 10 months ago (2012-02-20 17:51:56 UTC) #1
viettrungluu
LGTM. (I guess it was legal C++, though I'm surprised a warning wasn't generated.)
8 years, 10 months ago (2012-02-20 22:11:13 UTC) #2
jam
brettw for owners approval
8 years, 10 months ago (2012-02-21 01:30:10 UTC) #3
brettw
8 years, 10 months ago (2012-02-21 01:46:36 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698